=Fixed timeline CRUD.js issue where this.activeItem was set null when we st...

Jake Vanderwerf

2026-01-11 474109a5df0a06f5343ab184838fe2d80e3872a8

 inc/ui/CRUDSkeleton.php

@@ -604,17 +604,19 @@
   protected function renderContent(): void {
      $dataIgnore = $this->useCRUDjs ? '' : ' data-ignore';
      ?>
      <section class="items-list <?= esc_attr($this->dataType) ?> crud" data-content="<?= esc_attr($this->dataType) ?>" data-view="<?= $this->defaultView?>"<?=$dataIgnore?>>
         <?php
         $this->renderControlsAndFilters();
      <section class="items-list <?= esc_attr($this->dataType) ?> crud" data-content="<?= esc_attr($this->dataType) ?>" data-singular="<?=$this->singular?>" data-plural="<?=$this->plural?>" data-view="<?= $this->defaultView?>"<?=$dataIgnore?>>
         <div class="wrap">
            <?php
            $this->renderControlsAndFilters();

         if ($this->showBulkControls) {
            $this->renderBulkActions();
         }
         ?>
            if ($this->showBulkControls) {
               $this->renderBulkActions();
            }
            ?>

         <div class="<?= esc_attr($this->dataType) ?> item-grid" role="grid"></div>
         <div class="scroll-sentinel" aria-hidden="true"></div>
            <div class="<?= esc_attr($this->dataType) ?> item-grid" role="grid"></div>
            <div class="scroll-sentinel" aria-hidden="true"></div>
         </div>
      </section>
      <?php
   }
@@ -628,7 +630,7 @@
      }
      ?>
      <details class="all-filters col start" data-ignore>
         <summary>Filters</summary>
         <summary>Filters <button hidden data-action="clear-filters" data-ignore><?=jvbIcon('x')?><span>Clear Filters</span></span></button></summary>
         <?php

         $this->renderSearch();
@@ -640,6 +642,7 @@
            $this->renderColumnSelector();
         }
         ?>
         <button data-action="refresh" data-ignore><?=jvbIcon('arrows-clockwise')?><span>Hard Refresh</span></span></button>
      </details>
      <?php
   }
@@ -747,8 +750,11 @@
               $i = 0;
               foreach ($option as $opt => $label) {
                  $icon = $opt === 'date' ? 'calendar' : $opt;
                  $value = $opt;
                  $value = ($value === 'sort-ascending') ? 'asc' : $value;
                  $value = ($value === 'sort-descending') ? 'desc' : $value;
                  ?>
                  <input id="<?=$opt?>" class="btn" type="radio" name="<?=$o?>" data-filter="<?=$o?>" value="<?=$opt?>"<?=$i===0 ? ' checked':''?>>
                  <input id="<?=$opt?>" class="btn" type="radio" name="<?=$o?>" data-filter="<?=$o?>" value="<?=$value?>"<?=$i===0 ? ' checked':''?>>

                  <label for="<?=$opt?>" title="<?=$label?>"><?=jvbDashIcon($icon)?></label>
                  <?php
@@ -822,11 +828,11 @@
               <label for="date-start" class="col">
                  From
               </label>
               <input type="date" id="date-start" class="date-start">
               <input type="date" id="date-start" class="date-start" name="date-start">
               <label for="date-end" class="col">
                  To
               </label>
               <input type="date" id="date-end" class="date-end">
               <input type="date" id="date-end" class="date-end" name="date-end">
            </div>
            <div class="month-picker">
               <label>
@@ -870,7 +876,7 @@
      $out = '';
      if (!empty($terms)) {
         $out .= sprintf(
            '<div class="row nowrap"><label for="filter-%s">%s<span class="screen-reader-text">Filter by %s</span></label>
            '<div class="row nowrap"><label class="m-0" for="filter-%s">%s<span class="screen-reader-text">Filter by %s</span></label>
                <select id="filter-%s" class="filter %s" name="%s" data-filter="taxonomies" data-taxonomy="%s">
                <option value="">by %s</option>',
            $taxonomy,
@@ -986,7 +992,7 @@
            }
            foreach ($this->taxonomies as $taxonomy => $config) {
               ?>
               <option value="tax-<?=$taxonomy?>">Add to <?= JVB_TAXONOMY[$taxonomy]['singular']??$config['label'] ?></option>
               <option value="tax-<?=$taxonomy?>" data-type="selector" data-single="<?=JVB_TAXONOMY[$taxonomy]['singular']?>" data-plural="<?=JVB_TAXONOMY[$taxonomy]['plural']?>" data-taxonomy="<?=$taxonomy?>">Add to <?= JVB_TAXONOMY[$taxonomy]['singular']??$config['label'] ?></option>
               <?php
            }
            ?>
@@ -1169,11 +1175,11 @@
            <?= $this->renderItemSelect()?>
            <?=$this->renderImage() ?>
            <div class="col start w-full">
               <?= $this->renderItemActions()?>
               <h3 data-field="post_title"></h3>
               <p data-attr="date"></p>
               <p data-field="price"></p>
               <div data-field="post_excerpt"></div>
               <?= $this->renderItemActions()?>
            </div>
         </div>
      </template>