From 0afb2c0046b55c123eafb4ab9ee77efa68d12463 Mon Sep 17 00:00:00 2001
From: Jake Vanderwerf <get@jakevanderwerf.ca>
Date: Sat, 06 Jun 2026 17:15:31 +0000
Subject: [PATCH] =Starting the Favourites.js setup, converting previous Northeh stuff to new Registrar, fixing up Square.php integration to match

---
 inc/registrar/Registrar.php |   45 +++++++++++++++++++++++++++++++++++++++------
 1 files changed, 39 insertions(+), 6 deletions(-)

diff --git a/inc/registrar/Registrar.php b/inc/registrar/Registrar.php
index 88668ec..19b92fd 100644
--- a/inc/registrar/Registrar.php
+++ b/inc/registrar/Registrar.php
@@ -52,6 +52,8 @@
 	public bool $prefix_post_type = false;
 	public string $prefix_with = 'by';
 
+	public bool $system = false;
+
 	protected static array $allFlags = [
 		//Shared Flags
 		'favouritable', 'karma', 'show_feed', 'show_directory', 'approve_new', 'has_responses', 'invitable',
@@ -60,7 +62,9 @@
 		//Taxonomy Flags
 		'is_content', 'is_ownable', 'verify_entry', 'track_changes', 'associate_user_content', 'prefix_post_type',
 		//User Flags
-		'has_dashboard', 'can_register', 'can_create', 'keep_stats', 'can_favourite', 'member_verified', 'profile_link', 'manage_others'
+		'has_dashboard', 'can_register', 'can_create', 'keep_stats', 'can_favourite', 'member_verified', 'profile_link', 'manage_others',
+		//System
+		'system'
 	];
 	/**********************************************************************************************
 	SHARED FLAGS
@@ -244,7 +248,7 @@
 
 		$features = ['hide_single', 'is_timeline'];
 		foreach ($features as $feature) {
-			foreach (self::getFeatured($feature) as $instance) {
+			foreach (self::withFeature($feature) as $instance) {
 				$instance = self::getInstance($instance);
 				$cache = Cache::for('tsf')->connect($instance->getType());
 				$cache->flush();
@@ -465,7 +469,7 @@
 		return $this->integrationConfigs;
 	}
 	public function hasIntegration(string $integration) {
-		return in_array($integration, $this->integrationConfigs);
+		return array_key_exists($integration, $this->integrationConfigs);
 	}
     public function hasAnyIntegrations(array $integrations = []):bool
     {
@@ -582,8 +586,20 @@
 		}
 		return isset($this->$feature) && $this->$feature === true;
 	}
+
+	/**
+	 * @deprecated use withFeature
+	 * @param string $feature
+	 * @param string|null $type
+	 * @return array
+	 */
 	public static function getFeatured(string $feature, ?string $type = null):array
 	{
+		return self::withFeature($feature, $type);
+	}
+
+	public static function withFeature(string $feature, ?string $type = null):array
+	{
 		self::ensureInstanced();
 
 		if (!in_array($feature, static::$allFlags)) {
@@ -592,13 +608,30 @@
 		}
 
 		return array_map(function($inst) { return $inst->slug; },array_filter(self::$instances, function ($inst) use ($feature, $type){
-			if (!is_null($type) && $inst->type !== $type) {
+			if ((!is_null($type) && $inst->type !== $type) || $inst->system) {
 				return false;
 			}
 			return property_exists($inst, $feature) && isset($inst->$feature) && $inst->$feature === true;
 		}));
 	}
 
+	public static function withIntegration(string $integration, ?string $type = null):array
+	{
+		self::ensureInstanced();
+
+		if (!Site::has($integration)) {
+			error_log('[Registrar]::withIntegration Integration not available to fetch: '.$integration);
+			return [];
+		}
+
+		return array_map(function($inst) { return $inst->slug; },array_filter(self::$instances, function ($inst) use ($integration, $type){
+			if (!is_null($type) && $inst->type !== $type) {
+				return false;
+			}
+			return array_key_exists($integration, $this->integrationConfigs);
+		}));
+	}
+
 	public function config(string $config):mixed
 	{
 		$allowed = ['breadcrumbs','calendar','dashboard','directory','feed','management','has_responses','seo','trackchanges','verification'];
@@ -800,7 +833,7 @@
 	{
 		self::ensureInstanced();
 		$instances = ($type) ? array_filter(static::$instances, function($instance) use ($type) {
-			return $instance->type === $type;
+			return $instance->type === $type && !$instance->system;
 		}) : static::$instances;
 		return array_keys($instances);
 	}
@@ -1107,7 +1140,7 @@
 
     public static function getProfileTypes():array
     {
-        $hasProfiles = self::getFeatured('profile_link');
+        $hasProfiles = self::withFeature('profile_link');
         if (empty($hasProfiles)) {
             return [];
         }

--
Gitblit v1.10.0