From 235ce5716edc2f7cbe80fdccf26eac7269587839 Mon Sep 17 00:00:00 2001
From: Jake Vanderwerf <get@jakevanderwerf.ca>
Date: Mon, 08 Jun 2026 04:38:18 +0000
Subject: [PATCH] =FavouritesManager.php and FavouritesRoutes.php fixes. Moving all logic to FavouritesManager.php. Still some left to do

---
 inc/rest/routes/UploadRoutes.php |   33 ++++++++++++++++++++++-----------
 1 files changed, 22 insertions(+), 11 deletions(-)

diff --git a/inc/rest/routes/UploadRoutes.php b/inc/rest/routes/UploadRoutes.php
index 86ecc06..5222e4d 100644
--- a/inc/rest/routes/UploadRoutes.php
+++ b/inc/rest/routes/UploadRoutes.php
@@ -4,12 +4,12 @@
 use JVBase\managers\queue\executors\UploadExecutor;
 use JVBase\managers\queue\mergers\UploadMerger;
 use JVBase\managers\queue\TypeConfig;
+use JVBase\registrar\Registrar;
 use JVBase\rest\PermissionHandler;
 use JVBase\rest\Rest;
 use JVBase\meta\Meta;
 use JVBase\managers\UploadManager;
 use JVBase\rest\Route;
-use JVBase\utility\Features;
 use WP_REST_Request;
 use WP_REST_Response;
 use WP_Error;
@@ -130,6 +130,8 @@
     {
         $data = $request->get_params();
 		$args = [];
+		$registrar = Registrar::getInstance($data['content']??'');
+
 		foreach ($data as $key => $value) {
 			switch ($key) {
 				case 'depends_on':
@@ -140,15 +142,25 @@
 				case 'item_id':
 					if (is_numeric($value)) {
 						$args['item_id'] = absint($value);
-						if (!array_key_exists('post_id', $args)) {
-							$args['post_id'] = absint($value);
+						if ($registrar) {
+							switch ($registrar->getType()) {
+								case 'post':
+									$args['post_id'] = absint($value);
+									break;
+								case 'term':
+									$args['term_id'] = absint($value);
+									break;
+								case 'user':
+									$args['user_id'] = absint($value);
+									break;
+							}
 						}
 					}
 					break;
 				// Post Type/Taxonomy
 				case 'content':
-					$key = str_replace('-', '_', $key);
-					if ($value === 'options' || array_key_exists($value, JVB_CONTENT) || Features::forTaxonomy($key)->has('is_content')) {
+					$value = str_replace('-', '_', $value);
+					if ($value === 'options' || $registrar) {
 						$args['content'] = $value;
 					}
 					break;
@@ -168,7 +180,7 @@
 							!array_key_exists('post_id', $data) &&
 							!array_key_exists('term_id', $data) &&
 							!array_key_exists('item_id', $data)) {
-							$args['post_id'] = (int)get_user_meta((int) $value, BASE.'link', true);
+							$args['post_id'] = (int)get_user_meta((int) $value, BASE.'profile_link', true);
 						}
 					}
 					break;
@@ -627,7 +639,7 @@
 		} elseif (array_key_exists('term_id', $data)) {
 			$meta = Meta::forTerm($data['term_id']);
 		} else {
-			$link = (int)get_user_meta($data['user'], BASE.'link');
+			$link = (int)get_user_meta($data['user'], BASE.'profile_link');
 			$meta = Meta::forPost($link);
 		}
 
@@ -640,7 +652,6 @@
 
 		// Update with comma-separated string
 		$meta->set($data['field_name'], implode(',', $all_ids));
-		$meta->save();
 	}
 
 	/**
@@ -1090,9 +1101,9 @@
 		if (!empty($args['content']) && !empty($args['field_name'])) {
 			$content_type = $args['content'];
 			$field_name = $args['field_name'];
-
-			if (array_key_exists($content_type, JVB_CONTENT)) {
-				$content_fields = JVB_CONTENT[$content_type]['fields'] ?? [];
+			$registrar = Registrar::getInstance($content_type);
+			if ($registrar) {
+				$content_fields = $registrar->getFields();
 				if (array_key_exists($field_name, $content_fields)) {
 					$field_def = $content_fields[$field_name];
 

--
Gitblit v1.10.0