From 3b83905603d44b1a08f8b2b36a605808ce686ad6 Mon Sep 17 00:00:00 2001
From: Jake Vanderwerf <get@jakevanderwerf.ca>
Date: Tue, 02 Jun 2026 00:46:48 +0000
Subject: [PATCH] =double checking schema outputs for legacytattooremoval

---
 inc/rest/routes/FavouritesRoutes.php |   22 +++++++++++++---------
 1 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/inc/rest/routes/FavouritesRoutes.php b/inc/rest/routes/FavouritesRoutes.php
index f127aae..3494f5b 100644
--- a/inc/rest/routes/FavouritesRoutes.php
+++ b/inc/rest/routes/FavouritesRoutes.php
@@ -3,6 +3,7 @@
 
 use JVBase\managers\Cache;
 use JVBase\managers\CustomTable;
+use JVBase\registrar\Registrar;
 use JVBase\rest\PermissionHandler;
 use JVBase\rest\Response;
 use JVBase\rest\Rest;
@@ -41,7 +42,7 @@
 		$this->sharedListsCache = Cache::for('sharedLists')->connect('favourites', true);
 		$this->favouritesCache = Cache::for('allFavourites')->connect('favourites', true);
 
-		$this->valid_types = array_keys(array_merge(JVB_CONTENT, JVB_TAXONOMY));
+		$this->valid_types = array_merge(Registrar::getRegistered('post'), Registrar::getRegistered('term'));
 
 		// Initialize CustomTable instances
 		$this->favourites = CustomTable::for('favourites');
@@ -80,7 +81,8 @@
 				'notes' => 'string',
 			])
 			->auth(PermissionHandler::combine(['user', ['actionNonce' => 'favourites-']]))
-			->rateLimit(30);
+			->rateLimit(30)
+			->register();
 
 		// Lists endpoints
 		Route::for('favourites/lists')
@@ -98,13 +100,15 @@
 				'items' => 'array',
 			])
 			->auth(PermissionHandler::combine(['user', ['actionNonce' => 'favourites-']]))
-			->rateLimit(20);
+			->rateLimit(20)
+			->register();
 
 		// Favourite counts
 		Route::for('favourites/counts')
 			->get([$this, 'getFavouriteCounts'])
 			->args(['user' => 'integer|required'])
-			->auth(PermissionHandler::combine(['user', ['actionNonce' => 'favourites-']]));
+			->auth(PermissionHandler::combine(['user', ['actionNonce' => 'favourites-']]))
+			->register();
 	}
 
 	/**
@@ -501,7 +505,7 @@
 			'target_id' => $target_id
 		]);
 
-		if ($result['created']) {
+		if ((bool)$result) {
 			$this->updateFavouriteCount($type, $target_id);
 			$this->maybeNotifyOwner($type, $target_id, $user_id);
 		}
@@ -578,13 +582,13 @@
 							'type' => $type,
 							'target_id' => $target_id
 						]);
-						if ($result['created']) $results['added']++;
+						if ((bool) $result) $results['added']++;
 					} else {
-						$deleted = $table->where([
+						$deleted = $table->delete([
 							'user_id' => $user_id,
 							'type' => $type,
 							'target_id' => $target_id
-						])->deleteResults();
+						]);
 						if ($deleted) $results['removed']++;
 					}
 
@@ -844,7 +848,7 @@
 
 		$args = array_merge($args, [
 			'page' => max(1, absint($data['page'] ?? 1)),
-			'content' => $this->checkContent($data['content'] ?? 'all')
+			'content' => Registrar::getInstance($data['content']) ? $data['content'] : 'all',
 		]);
 
 		return $this->applyOrderFilters($args, $data);

--
Gitblit v1.10.0