From 772462eeca3002a1d52508aeba485aab2b4742ad Mon Sep 17 00:00:00 2001
From: Jake Vanderwerf <get@jakevanderwerf.ca>
Date: Tue, 03 Mar 2026 19:06:19 +0000
Subject: [PATCH] =MAJOR OVERHAUL. Likely should have made a new branch ages ago. Key changes: Registrar.php is the base for custom post types, taxonomies, and user roles. Replaces JVB_CONTENT, JVB_TAXONOMY, and JVB_USER constants, eliminates most of Features.php (except for JVB_SITE, JVB_MEMBERSHIP), and has built in sanitizing and validation via sub-classes. Also started a major overhaul of the Schema output. Created a shit ton of property traits and classes to help sanitize and ensure proper data for different schema types. Still a bunch to do, but better to be starting committing changes here on this other branch.

---
 inc/forms/TaxonomySelector.php |   17 ++++++++++++-----
 1 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/inc/forms/TaxonomySelector.php b/inc/forms/TaxonomySelector.php
index bcc5a3b..5af59da 100644
--- a/inc/forms/TaxonomySelector.php
+++ b/inc/forms/TaxonomySelector.php
@@ -1,6 +1,7 @@
 <?php
 namespace JVBase\forms;
 
+use JVBase\registrar\Registrar;
 use WP_Term;
 
 if (!defined('ABSPATH')) {
@@ -27,13 +28,19 @@
 	protected string $base;
 	protected string $title;
 	protected array $config;
+	protected Registrar $registrar;
 
 	public function __construct(string $id, string $taxonomy, array $config = []) {
 		$this->id = sanitize_key($id);
 		$this->taxonomy = jvbCheckBase($taxonomy);
 		$this->name = jvbNoBase($taxonomy);
 
-		$this->title = JVB_TAXONOMY[$this->name]['plural'];
+		$registrar = Registrar::getInstance($this->name);
+		if ($registrar) {
+			$this->registrar = $registrar;
+		}
+
+		$this->title = $registrar->getPlural();
 		$this->base = $config['base']??'';
 		$this->config = wp_parse_args($config, [
 			'types'		=> false, // for feed block implementation
@@ -50,8 +57,8 @@
 			'update'	=> true,   // Whether to update on close
 		]);
 
-		$this->plural = JVB_TAXONOMY[$taxonomy]['plural'];
-		$this->singular = JVB_TAXONOMY[$taxonomy]['singular'];
+		$this->plural = $registrar->getPlural();
+		$this->singular = $registrar->getSingular();
 	}
 
 
@@ -272,12 +279,12 @@
 	{
 		return sprintf(
 			'<button type="button" data-icon="%s" data-filter="taxonomy" data-taxonomy="%s" data-type="selector" data-single="%s" data-plural="%s" title="Filter by %s">%s<span class="label">%s</span></button>',
-			JVB_TAXONOMY[$this->name]['icon'],
+			$this->registrar->getIcon(),
 			$this->name,
 			$this->singular,
 			$this->plural,
 			$this->singular,
-			jvbIcon($this->config['icon']),
+			jvbIcon($this->registrar->getIcon()),
 			$this->singular
 		);
 	}

--
Gitblit v1.10.0