From 9f86429a1252b45c95b7c62fbaa1b82de3723997 Mon Sep 17 00:00:00 2001
From: Jake Vanderwerf <get@jakevanderwerf.ca>
Date: Mon, 05 Jan 2026 18:16:07 +0000
Subject: [PATCH] =Complete TaxonomySelector.js and TaxonomyCreator.js refactor
---
inc/ui/CRUDSkeleton.php | 19 ++++++++++---------
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/inc/ui/CRUDSkeleton.php b/inc/ui/CRUDSkeleton.php
index 8390fc3..7347c63 100644
--- a/inc/ui/CRUDSkeleton.php
+++ b/inc/ui/CRUDSkeleton.php
@@ -36,7 +36,7 @@
protected string $dataType = '';
protected string $singular = '';
protected string $plural = '';
- protected string $icon = 'triangle';
+ protected string $icon;
// Capabilities
protected array $caps = [];
@@ -134,6 +134,7 @@
protected array $additionalClasses = [];
public function __construct() {
+ $this->icon = jvbDefaultIcon();
$this->user = wp_get_current_user();
$this->user_id = $this->user->ID;
}
@@ -238,7 +239,7 @@
/**
* Add a view type (grid, table, list, timeline)
*/
- public function addViews(?array $views):self
+ public function addViews(?array $views = null):self
{
if (!$views) {
$views = $this->defaultViews;
@@ -612,7 +613,8 @@
return;
}
?>
- <div class="all-filters col start" data-ignore>
+ <details class="all-filters col start" data-ignore>
+ <summary>Filters</summary>
<?php
$this->renderSearch();
@@ -624,7 +626,7 @@
$this->renderColumnSelector();
}
?>
- </div>
+ </details>
<?php
}
@@ -1111,7 +1113,7 @@
}
ob_start();
?>
- <div class="item-actions">
+ <div class="item-actions row btw abs">
<?php
foreach ($this->itemActions as $action) {
$config = $this->defaultItemActions[$action];
@@ -1698,7 +1700,7 @@
protected function getApplicableStatuses(string $prefix) {
foreach ($this->statuses as $status) {
- if ($status === 'all' || !in_array($status, $this->allowedStatuses)) {
+ if ($status === 'all' || !array_key_exists($status, $this->allowedStatuses)) {
continue;
}
$config = $this->allowedStatuses[$status];
@@ -1721,9 +1723,8 @@
value="<?= esc_attr($status)?>"
id="<?=$prefix?>set-<?= esc_attr($status) ?>"
<?= $disabled?>>
- <label for="<?=$prefix?>set-<?=esc_attr($status)?>">
- <?= jvbDashIcon($config['icon'], ['title' => $config['label']]) ?>
- <span><?= esc_html($config['label'])?></span>
+ <label for="<?=$prefix?>set-<?=esc_attr($status)?>" title="<?=esc_html($config['label'])?>">
+ <?= jvbDashIcon($config['icon']) ?>
</label>
<?php
}
--
Gitblit v1.10.0