From a9654f00c8fbc9934289d761843ddd071025013f Mon Sep 17 00:00:00 2001
From: Jake Vanderwerf <get@jakevanderwerf.ca>
Date: Fri, 28 Aug 2026 17:20:28 +0000
Subject: [PATCH] =PHPStorm Code Inspection: fixed class reference errors (from getting rid of JVB() and replacing with direct class::getInstance; as well as general code sniffing, etc
---
inc/rest/routes/NewsRoutes.php | 18 ++++++++++--------
1 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/inc/rest/routes/NewsRoutes.php b/inc/rest/routes/NewsRoutes.php
index b0aedfc..8cf885d 100644
--- a/inc/rest/routes/NewsRoutes.php
+++ b/inc/rest/routes/NewsRoutes.php
@@ -1,6 +1,8 @@
<?php
namespace JVBase\rest\routes;
+use JVBase\Instance;
+use JVBase\managers\queue\Queue;
use JVBase\rest\PermissionHandler;
use JVBase\rest\Rest;
use JVBase\meta\Meta;
@@ -17,6 +19,7 @@
class NewsRoutes extends Rest
{
+ use Instance;
protected int $per_page;
protected bool|object $manager = false;
public function __construct()
@@ -52,7 +55,6 @@
->rateLimit(20)
->post([$this, 'handleNewsOperation'])
->args([
- 'user' => 'integer|required',
'id' => 'string|required',
'post_title' => 'string|required',
'post_excerpt' => 'string',
@@ -78,9 +80,9 @@
*/
public function handleNewsOperation(WP_REST_Request $request):WP_REST_Response
{
- $queue = JVB()->queue();
+ $queue = Queue::getInstance();
$data = $request->get_params();
- $user = absint($data['user']);
+ $user = get_current_user_id();
$operationID = sanitize_text_field($data['id']);
unset($data['user']);
@@ -107,8 +109,8 @@
public function getNews(WP_REST_Request $request):WP_REST_Response
{
$args = $this->buildQueryArgs($request);
- $key = $this->cache->generateKey($args);
- $cache = $this->cache->get($key);
+
+ $cache = $this->cache->get($args);
if ($cache) {
return $this->success($cache);
}
@@ -124,7 +126,7 @@
'total_pages' => $query->max_num_pages
];
- $this->cache->set($key, $results);
+ $this->cache->set($args, $results);
return $this->success($results);
}
@@ -198,7 +200,7 @@
{
if (array_key_exists('orderby', $data) && $data['orderby'] === 'random') {
// Handle random ordering
- $current_seed = jvbGetRandomSeed();
+ $current_seed = floor(time() / 1800);
$args['orderby'] = 'RAND(' . $current_seed . ')';
unset($args['order']);
} else {
@@ -324,7 +326,7 @@
$artist = jvbContentFromUser($post->post_author);
$upvotes = (int) get_post_meta($post->ID, BASE.'upvotes', true);
$downvotes = (int) get_post_meta($post->ID, BASE.'downvotes', true);
- $comments = JVB()->routes('comments')->getItemResponse($post->ID, BASE.'news');
+ $comments = ResponseRoutes::getInstance()->getItemResponse($post->ID, ['post_type' => BASE.'news']);
return [
'id' => $post->ID,
--
Gitblit v1.10.0