From ac444cba221832c012c0435fdc8339fe9f37febb Mon Sep 17 00:00:00 2001
From: Jake Vanderwerf <get@jakevanderwerf.ca>
Date: Mon, 11 May 2026 18:35:04 +0000
Subject: [PATCH] =Some changes to the CRUD.js editing, timeline post configuration

---
 inc/ui/CRUDSkeleton.php |  291 ++++++++++++++++++++++++++++++++++-----------------------
 1 files changed, 174 insertions(+), 117 deletions(-)

diff --git a/inc/ui/CRUDSkeleton.php b/inc/ui/CRUDSkeleton.php
index e8c0478..b5e977a 100644
--- a/inc/ui/CRUDSkeleton.php
+++ b/inc/ui/CRUDSkeleton.php
@@ -1,9 +1,10 @@
 <?php
 namespace JVBase\ui;
 
+use JVBase\base\Site;
 use JVBase\managers\UserTermsManager;
-use JVBase\meta\MetaForm;
-use JVBase\meta\MetaManager;
+use JVBase\meta\Form;
+use JVBase\registrar\Registrar;
 use WP_User;
 
 if (!defined('ABSPATH')) {
@@ -118,13 +119,8 @@
 	protected ?array $uploaderConfig = null;
 
 	// Data
-	protected $dataSourceCallback = null;
 	protected array $templates = [];
 
-	// Metadata handling
-	protected ?MetaManager $meta = null;
-	protected ?MetaForm $form = null;
-
 	// UI Options
 	protected array $stuck = []; // Fields that stick when scrolling
 	protected bool $showHeader = true;
@@ -133,6 +129,7 @@
 	protected array $customDateRanges = [];
 	protected array $additionalClasses = [];
 
+	protected ?Registrar $registrar;
 	public function __construct() {
 		$this->icon = jvbDefaultIcon();
 		$this->user = wp_get_current_user();
@@ -153,6 +150,12 @@
 	 */
 	public function content(string $type, string $singular, string $plural): self {
 		$this->dataType = $type;
+		$registrar = Registrar::getInstance($type);
+		if ($registrar) {
+			$this->registrar = Registrar::getInstance($type)??null;
+			$this->sections = $this->registrar->getSections();
+		}
+
 		$this->singular = $singular;
 		$this->plural = $plural;
 		return $this;
@@ -218,18 +221,43 @@
 	 */
 	public function addTaxonomyFilter(array $taxonomies, ?string $limit = null): self {
 		foreach($taxonomies as $taxonomy) {
-			$this->taxonomies[$taxonomy] = [
-				'type'	=> 'taxonomy',
-				'taxonomy'=> $taxonomy,
-				'limit'	=> $limit,
-				'label'	=> JVB_TAXONOMY[$taxonomy]['plural']??'',
-				'icon'	=> JVB_TAXONOMY[$taxonomy]['icon']??''
-			];
+			$registrar = Registrar::getInstance($taxonomy);
+
+			if ($registrar) {
+				$this->taxonomies[$taxonomy] = [
+					'type'	=> 'taxonomy',
+					'taxonomy'=> $taxonomy,
+					'limit'	=> $limit,
+					'label'	=> $registrar->getPlural(),
+					'icon'	=> $registrar->getIcon()
+				];
+			}
 		}
 
 		return $this;
 	}
 
+	protected function taxConfig(string $taxonomy, string $label = ''):array
+	{
+		$isVerified = $this->userIsVerified();
+		$label = ($label === '') ? Registrar::getInstance($taxonomy)->getPlural() : $label;
+		return [
+			'type'		=> 'taxonomy',
+			'label'		=> $label,
+			'taxonomy'	=> $taxonomy,
+			'createNew' => $isVerified,
+			'multiple'	=> true,
+			'mode'		=> 'append',
+		];
+	}
+
+	protected function userIsVerified():bool
+	{
+		$membership = Site::membership();
+
+		return !($membership && $membership->has('member_verified')) || current_user_can('skip_moderation');
+	}
+
 	public function addSearch():self
 	{
 		$this->hasSearch = true;
@@ -327,14 +355,12 @@
 		}
 
 		$this->timelineSharedFields = array_keys(array_filter($this->fields, function ($field) {
-			if (!array_key_exists('for_all', $field) || $field['for_all'] === false){
+			if (!array_key_exists('for_all', $field) || $field['for_all'] === false || is_null($field['for_all'])){
 				return true;
 			}
 			return false;
 		}));
-		array_unshift($this->timelineSharedFields, 'post_thumbnail');
 		array_unshift($this->timelineSharedFields, 'post_title');
-		array_unshift($this->timelineSharedFields, 'post_status');
 
 		$this->timelineUniqueFields = array_keys(array_filter($this->fields, function ($field) {
 			if (array_key_exists('for_all', $field) && $field['for_all'] === true) {
@@ -443,15 +469,6 @@
 	}
 
 	/**
-	 * Set the data source callback
-	 * Callback should accept filters and return array of items
-	 */
-	public function dataSource(callable $callback): self {
-		$this->dataSourceCallback = $callback;
-		return $this;
-	}
-
-	/**
 	 * Add a custom template
 	 */
 	public function addTemplate(string $name, string $template): self {
@@ -485,14 +502,6 @@
 		return $this;
 	}
 
-	/**
-	 * Initialize meta handling
-	 */
-	public function initMeta(string $objectType = 'post', ?string $content = null): self {
-		$this->meta = new MetaManager(null, $objectType, $content ?? $this->dataType);
-		$this->form = new MetaForm();
-		return $this;
-	}
 
 	/**
 	 * Build the configuration array
@@ -527,7 +536,7 @@
 		$config = $this->build();
 		$classes = array_merge(['dashboard-page', $this->dataType], $this->additionalClasses);
 
-		ob_start();
+//		ob_start();
 		?>
 		<div class="<?= esc_attr(implode(' ', $classes)) ?>" data-type="<?= esc_attr($this->dataType) ?>">
 			<?php
@@ -540,7 +549,7 @@
 			?>
 		</div>
 		<?php
-		echo ob_get_clean();
+//		echo ob_get_clean();
 	}
 
 	/**
@@ -567,16 +576,13 @@
 	 * Render uploader section
 	 */
 	protected function renderUploader(): void {
-		if (!$this->meta) {
-			return;
-		}
 		?>
 		<details open class="uploader">
 			<summary class="row btw"><?= esc_html($this->uploaderConfig['label'] ?? 'Upload Files') ?></summary>
 			<?php
-			$this->meta->render(
-				'form',
+			echo Form::render(
 				'new_' . $this->dataType,
+				'',
 				$this->uploaderConfig
 			);
 			?>
@@ -590,17 +596,19 @@
 	protected function renderContent(): void {
 		$dataIgnore = $this->useCRUDjs ? '' : ' data-ignore';
 		?>
-		<section class="items-list <?= esc_attr($this->dataType) ?> crud" data-content="<?= esc_attr($this->dataType) ?>" data-view="<?= $this->defaultView?>"<?=$dataIgnore?>>
-			<?php
-			$this->renderControlsAndFilters();
+		<section class="items-list <?= esc_attr($this->dataType) ?> crud" data-content="<?= esc_attr($this->dataType) ?>" data-singular="<?=$this->singular?>" data-plural="<?=$this->plural?>" data-view="<?= $this->defaultView?>"<?=$dataIgnore?>>
+			<div class="wrap">
+				<?php
+				$this->renderControlsAndFilters();
 
-			if ($this->showBulkControls) {
-				$this->renderBulkActions();
-			}
-			?>
+				if ($this->showBulkControls) {
+					$this->renderBulkActions();
+				}
+				?>
 
-			<div class="<?= esc_attr($this->dataType) ?> item-grid" role="grid"></div>
-			<div class="scroll-sentinel" aria-hidden="true"></div>
+				<div class="<?= esc_attr($this->dataType) ?> item-grid" role="grid"></div>
+				<div class="scroll-sentinel" aria-hidden="true"></div>
+			</div>
 		</section>
 		<?php
 	}
@@ -626,7 +634,9 @@
 				$this->renderColumnSelector();
 			}
 			?>
+			<button data-action="refresh" data-ignore><?=jvbIcon('arrows-clockwise')?><span>Hard Refresh</span></span></button>
 		</details>
+		<button hidden data-action="clear-filters" data-ignore hidden><?=jvbIcon('x')?><span>Clear Filters</span></span></button>
 		<?php
 	}
 
@@ -733,8 +743,11 @@
 					$i = 0;
 					foreach ($option as $opt => $label) {
 						$icon = $opt === 'date' ? 'calendar' : $opt;
+						$value = $opt;
+						$value = ($value === 'sort-ascending') ? 'asc' : $value;
+						$value = ($value === 'sort-descending') ? 'desc' : $value;
 						?>
-						<input id="<?=$opt?>" class="btn" type="radio" name="<?=$o?>" data-filter="<?=$o?>" value="<?=$opt?>"<?=$i===0 ? ' checked':''?>>
+						<input id="<?=$opt?>" class="btn" type="radio" name="<?=$o?>" data-filter="<?=$o?>" value="<?=$value?>"<?=$i===0 ? ' checked':''?>>
 
 						<label for="<?=$opt?>" title="<?=$label?>"><?=jvbDashIcon($icon)?></label>
 						<?php
@@ -808,11 +821,11 @@
 					<label for="date-start" class="col">
 						From
 					</label>
-					<input type="date" id="date-start" class="date-start">
+					<input type="date" id="date-start" class="date-start" name="date-start">
 					<label for="date-end" class="col">
 					   To
 					</label>
-					<input type="date" id="date-end" class="date-end">
+					<input type="date" id="date-end" class="date-end" name="date-end">
 				</div>
 				<div class="month-picker">
 					<label>
@@ -856,7 +869,7 @@
 		$out = '';
 		if (!empty($terms)) {
 			$out .= sprintf(
-				'<div class="row nowrap"><label for="filter-%s">%s<span class="screen-reader-text">Filter by %s</span></label>
+				'<div class="row nowrap"><label class="m-0" for="filter-%s">%s<span class="screen-reader-text">Filter by %s</span></label>
                 <select id="filter-%s" class="filter %s" name="%s" data-filter="taxonomies" data-taxonomy="%s">
                 <option value="">by %s</option>',
 				$taxonomy,
@@ -873,8 +886,8 @@
 			foreach ($terms as $term) {
 				$out .= sprintf(
 					'<option value="%s">%s</option>',
-					esc_attr($term['term_id']),
-					esc_html($term['name'])
+					esc_attr(is_object($term) ? $term->term_id : $term['term_id']),
+					esc_html(is_object($term) ? $term->name : $term['name'])
 				);
 			}
 			$out .= '</select></div>';
@@ -889,9 +902,9 @@
 	 */
 	protected function getCommonTerms(string $taxonomy, ?string $limit = null):array {
 		if ($limit) {
-			if ($limit === 'user') {
+			if (Site::has('membership') && $limit === 'user') {
 				$manager = new UserTermsManager();
-				return $manager->getUserTerms($this->user_id, $taxonomy);
+				return $manager->fetchUserTerms($this->user_id, $taxonomy);
 			} else {
 				$limit = (int)$limit;
 			}
@@ -970,9 +983,12 @@
 					<option value="<?=$control?>"<?=$disabled?>><?=$label?></option>
 					<?php
 				}
-				foreach ($this->taxonomies as $taxonomy => $config) {
+
+				foreach ($this->taxonomies as $taxonomy =>$config) {
+					$registrar = Registrar::getInstance($taxonomy);
+					if (!$registrar) continue;
 					?>
-					<option value="tax-<?=$taxonomy?>">Add to <?= JVB_TAXONOMY[$taxonomy]['singular']??$config['label'] ?></option>
+					<option value="tax-<?=$taxonomy?>" data-type="selector" data-single="<?=$registrar->getSingular()?>" data-plural="<?=$registrar->getPlural()?>" data-taxonomy="<?=$taxonomy?>">Add to <?= $registrar->getSingular() ?></option>
 					<?php
 				}
 				?>
@@ -1038,10 +1054,9 @@
 			$temp = array_filter($this->fields, function ($field) {
 				return in_array($field, $this->timelineUniqueFields);
 			}, ARRAY_FILTER_USE_KEY);
-			jvbDump($temp);
-			$form = new MetaForm();
+
 			echo '<template class="timelineItem">';
-			$form->renderImagePreview(null,['fields' => $temp]);
+			echo Form::renderImagePreview(null, $temp);
 			echo '</template>';
 		}
 		if (!array_key_exists('empty', $templates)) {
@@ -1094,8 +1109,8 @@
 		ob_start();
 		?>
 		<div class="item-select">
-			<input type="checkbox" class="select-item">
-			<label class="select-item-label">
+			<input type="checkbox" class="select-item" name="select-item" id="item">
+			<label class="select-item-label" for="item">
 				<span class="screen-reader-text">Select this <?= $this->singular ?></span>
 			</label>
 		</div>
@@ -1156,11 +1171,11 @@
 				<?= $this->renderItemSelect()?>
 				<?=$this->renderImage() ?>
 				<div class="col start w-full">
-					<?= $this->renderItemActions()?>
 					<h3 data-field="post_title"></h3>
 					<p data-attr="date"></p>
 					<p data-field="price"></p>
 					<div data-field="post_excerpt"></div>
+					<?= $this->renderItemActions()?>
 				</div>
 			</div>
 		</template>
@@ -1243,7 +1258,11 @@
 						<?php
 						if (in_array('edit', $this->caps)) {
 							echo $makeThisDetailed ? '<details><summary class="row btw">See Value</summary>' : '';
-							echo $this->meta->render('form', $name, $config);
+							if (in_array($config['type'], ['selector', 'taxonomy', 'post'])) {
+								$config['autocomplete'] = true;
+							}
+
+							echo Form::render($name, '', $config);
 							echo $makeThisDetailed ? '</details>' : '';
 						} else {
 							echo '<p></p>';
@@ -1321,7 +1340,12 @@
 					?>
 					<td class="field show-<?= esc_attr($name) ?>" data-field="<?= esc_attr($name) ?>" data-field-type="<?=$config['type']?>"<?=(in_array($name, $this->stuck)) ? ' data-stuck':''?>>
 						<?= $makeThisDetailed ? '<details><summary class="row btw">See Value</summary>' : '' ?>
-						<?php $this->meta->render('form', $name, $config); ?>
+						<?php
+						if (in_array($config['type'], ['selector', 'taxonomy', 'post'])) {
+							$config['autocomplete'] = true;
+						}
+						?>
+						<?= Form::render($name, '', $config); ?>
 						<?= $makeThisDetailed ? '</details>' : '' ?>
 					</td>
 					<?php
@@ -1349,7 +1373,7 @@
 					?>
 					<td class="field show-<?= esc_attr($name) ?>" data-field="<?= esc_attr($name) ?>" data-field-type="<?=$config['type']?>"<?=(in_array($name, $this->stuck)) ? ' data-stuck':''?>>
 						<?= $makeThisDetailed ? '<details><summary class="row btw">See Value</summary>' : '' ?>
-						<?php $this->meta->render('form', $name, $config); ?>
+						<?= Form::render($name, '', $config); ?>
 						<?= $makeThisDetailed ? '</details>' : '' ?>
 					</td>
 					<?php
@@ -1453,10 +1477,10 @@
 	protected function renderStatusRadios(): string {
 		ob_start();
 		?>
-		<div class="radio-options status-options row">
+		<div class="radio-options status-options row" data-field="post_status" data-field-type="radio">
 			<?php foreach ($this->statuses as $status):
 				if ($status === 'all') continue;
-				if (!in_array($status, $this->allowedStatuses)) continue;
+				if (!array_key_exists($status, $this->allowedStatuses)) continue;
 				$config = $this->allowedStatuses[$status];
 				?>
 
@@ -1469,6 +1493,7 @@
 					<span class="screen-reader-text"><?= esc_html($config['label']) ?></span>
 				</label>
 			<?php endforeach; ?>
+			<span class="validation-message" hidden role="alert"></span>
 		</div>
 		<?php
 		return ob_get_clean();
@@ -1531,19 +1556,15 @@
 			<input type="hidden" name="form-id" value="<?=uniqid('new-')?>" />
 			<input type="hidden" name="content" value="<?=$this->dataType?>" />
 			<div class="fields">
-				<div class="field-group radio-options row">
-					<span>Status:</span>
-					<?php
-					$this->getApplicableStatuses('edit');
-					?>
-				</div>
-				<?php if (!$this->userCanPublish) { ?>
-					<p class="description">Your account needs to be verified before you can publish content.</p>
-				<?php }
+				<?php
+				if (!empty($this->statuses)) {
+					echo Form::render('post_status', '', $this->getStatusFieldConfig('edit-'));
+				}
 
 				if (!empty($this->sections)) {
 					$tabs = [];
-					foreach ($this->sections as $slug => $config) {
+					foreach ($this->sections as $config) {
+						$slug = $config['slug'];
 						$section = [];
 						if (array_key_exists('icon', $config)) {
 							$section = [
@@ -1555,16 +1576,11 @@
 							'content' => '',
 							'description' => $config['description']??'',
 						], $section);
-						$icon = jvbSectionIcon($slug);
-						if ($icon !== '') {
-							$tabs[$slug]['icon'] = $icon;
-						}
 					}
 				} else {
 					$tabs = false;
 				}
 
-
 				$fields = $this->fields;
 				if (!$this->isTimeline) {
 					$first = ['post_thumbnail', 'post_title', 'price'];
@@ -1572,47 +1588,60 @@
 					foreach ($first as $f) {
 						if (array_key_exists($f, $fields)) {
 							if ($tabs) {
-								$tabs['basic']['content'] .= $this->meta->render('form', $f, $fields[$f], false, true);
+								$tabs['basic']['content'] .= Form::render($f, '', $fields[$f]);
 							} else {
-								$this->meta->render('form', $f, $fields[$f]);
+								echo Form::render($f, '', $fields[$f]);
 							}
-
 							unset($fields[$f]);
 						}
 					}
 				}
 
 				if ($this->isTimeline) {
-					$temp = array_filter($fields, function ($field) {
-						return in_array($field, $this->timelineUniqueFields);
+					$temp = array_filter($fields, function ($field) use ($fields) {
+						return in_array($field, $this->timelineUniqueFields) && (!array_key_exists('hidden', $fields[$field]) || $fields[$field]['hidden'] === false);
 					}, ARRAY_FILTER_USE_KEY);
-
 					$config = [
-						'type'		=> 'gallery',
+						'type'		=> 'upload',
 						'subtype'	=> 'timeline',
-						'data'		=> 'timeline',
+						'multiple'	=> true,
+						'limit'		=> 0,
+						'data'		=> ['timeline'],
 						'label'		=> 'Progression',
 						'fields'	=> $temp
 					];
 					$content = '';
 					foreach ($fields as $slug=> $field) {
 						if (in_array($slug, $this->timelineSharedFields)) {
-							$content .= $this->form->render($slug, null, $field, false, true);
+							if (in_array($field['type'], ['taxonomy', 'selector'])) {
+								$field = array_merge($field, $this->taxConfig($field['taxonomy'], $field['label']));
+							}
+							if (!array_key_exists('hidden', $field) || $field['hidden'] === false) {
+								$content .= Form::render($slug, '', $field);
+							}
 						}
 					}
 
 
-					$content .= $this->meta->render('form', 'timeline', $config, false,true);
+					$content .= Form::render('timeline_gallery', '', $config);
 
-					$tabs['progression']['content'] = $content;
+					if ($tabs) {
+						$tabs['progression']['content'] = $content;
+					} else {
+						echo $content;
+					}
+
 					$fields = $this->nonTimelineFields;
 				}
 				foreach ($fields as $n => $config) {
+					if (in_array($config['type'], ['taxonomy', 'selector'])) {
+						$config = array_merge($config, $this->taxConfig($config['taxonomy'], $config['label']));
+					}
 					if ($tabs) {
 						$section = (array_key_exists('section', $config)) ? $config['section'] : 'basic';
-						$tabs[$section]['content'] .= $this->meta->render('form', $n, $config, false, true);
+						$tabs[$section]['content'] .= Form::render($n, '', $config);
 					} else {
-						$this->meta->render('form', $n, $config);
+						echo Form::render($n, '', $config);
 					}
 				}
 
@@ -1624,6 +1653,7 @@
 		</form>
 		<?php
 		return ob_get_clean();
+//		return '';
 	}
 
 	protected function renderEditModal():void
@@ -1646,29 +1676,15 @@
 			<p class="description">You can unselect items by clicking the image here.</p>
 			<p class="hint"><strong>IMPORTANT: </strong> Whatever changes you make here will be applied to all selected <?=$this->plural?>.</p>
 			<div class="fields">
-				<div class="field-group radio-options row">
-					<?php
-					$this->getApplicableStatuses('bulk-');
-					?>
-				</div>
 				<?php
+				echo Form::render('post_status', '', $this->getStatusFieldConfig('bulk-'));
+
 				if (!empty($this->taxonomies)) {
 					?>
 					<div class="taxonomies">
 						<?php
 						foreach ($this->taxonomies as $taxonomy => $config) {
-							$this->meta->render(
-								'form',
-								'bulk-edit-'.$taxonomy,
-								[
-									'type'		=> 'taxonomy',
-									'label'		=> $config['label'],
-									'taxonomy'	=> $taxonomy,
-									'createNew'	=> jvbUserIsVerified(),
-									'multiple'	=> true,
-									'mode'		=> 'append'
-								]
-							);
+							echo Form::render('bulk-edit-'.$taxonomy, '', $this->taxConfig($taxonomy, $config['label']));
 						}
 						?>
 					</div>
@@ -1679,7 +1695,7 @@
 					return array_key_exists('bulkEdit', $field);
 				});
 				foreach ($fields as $fieldName => $config) {
-					$this->meta->render('form', $fieldName, $config);
+					echo Form::render($fieldName, '', $config);
 				}
 				?>
 			</div>
@@ -1699,7 +1715,46 @@
 		);
 	}
 
+	protected function getStatusFieldConfig(string $prefix): array
+	{
+		$options = [];
+		foreach ($this->statuses as $status) {
+			if ($status === 'all' || !array_key_exists($status, $this->allowedStatuses)) {
+				continue;
+			}
+			$config = $this->allowedStatuses[$status];
+
+			if (in_array($status, ['future', 'past'])) {
+				if ($status === 'future') {
+					$status = 'publish';
+					$config = ['icon' => 'eye', 'label' => 'Live'];
+				} else {
+					continue;
+				}
+			}
+
+			$options[$status] = [
+				'label'    => $config['label'],
+				'icon'     => $config['icon'],
+				'disabled' => ($status === 'publish' && !$this->userCanPublish),
+			];
+		}
+
+		return [
+			'type'       => 'radio',
+			'label'      => 'Status',
+			'options'    => $options,
+			'inputClass' => 'btn',
+			'idPrefix'   => $prefix,
+			'class'      => 'radio-options row',
+			'hint'       => !$this->userCanPublish
+				? 'Your account needs to be verified before you can publish content.'
+				: '',
+		];
+	}
+
 	protected function getApplicableStatuses(string $prefix) {
+		ob_start();
 		foreach ($this->statuses as $status) {
 			if ($status === 'all' || !array_key_exists($status, $this->allowedStatuses)) {
 				continue;
@@ -1729,5 +1784,7 @@
 			</label>
 			<?php
 		}
+		$out = ob_get_clean();
+		echo Form::fieldWrap('post_status', $out, ['type'=>'group']);
 	}
 }

--
Gitblit v1.10.0