From b38f03c0e7218762d90fa5092696b127f24f36db Mon Sep 17 00:00:00 2001
From: Jake Vanderwerf <get@jakevanderwerf.ca>
Date: Sun, 25 Jan 2026 07:07:26 +0000
Subject: [PATCH] =Some logical flaws in Queue.php, Queue.js, ContentExecutor.php, UploadExecutor.php - particularly with timeline ordering, frontend queue updates, etc
---
inc/managers/SEO/BreadcrumbManager.php | 33 +++++++++++++++------------------
1 files changed, 15 insertions(+), 18 deletions(-)
diff --git a/inc/managers/SEO/BreadcrumbManager.php b/inc/managers/SEO/BreadcrumbManager.php
index 0a23c5c..1eecb1b 100644
--- a/inc/managers/SEO/BreadcrumbManager.php
+++ b/inc/managers/SEO/BreadcrumbManager.php
@@ -1,7 +1,7 @@
<?php
namespace JVBase\managers\SEO;
-use JVBase\managers\CacheManager;
+use JVBase\managers\Cache;
use JVBase\utility\Features;
use WP_Post;
use WP_Term;
@@ -18,14 +18,14 @@
*/
class BreadcrumbManager
{
- private CacheManager $cache;
+ private Cache $cache;
private static ?self $instance = null;
private function __construct()
{
- $this->cache = CacheManager::for('breadcrumbs', MONTH_IN_SECONDS)->connectTo('all');
+ $this->cache = Cache::for('breadcrumbs', MONTH_IN_SECONDS)->connect('post')->connect('taxonomy')->connect('user');
if (JVB_TESTING) {
- $this->cache->clear();
+ $this->cache->flush();
}
}
@@ -65,16 +65,13 @@
break;
}
- $crumbs = $this->cache->get($key);
- if ($crumbs !== false) {
- return $crumbs;
- }
-
- $crumbs = $this->buildCrumbs();
- $crumbs = apply_filters('jvbBreadcrumbs',$crumbs);
- $this->cache->set($key, $crumbs);
-
- return $crumbs;
+ return $this->cache->remember(
+ $key,
+ function() {
+ $crumbs = $this->buildCrumbs();
+ return apply_filters('jvbBreadcrumbs',$crumbs);
+ }
+ );
}
/**
@@ -215,7 +212,7 @@
{
$url = get_term_link($term->term_id);
array_unshift($crumbs, [
- 'name' => $term->name,
+ 'name' => html_entity_decode($term->name),
'url' => $url,
'id' => $term->term_id,
]);
@@ -349,9 +346,9 @@
public function invalidateCache(?int $objectId = null): void
{
if ($objectId) {
- $this->cache->delete($objectId);
+ $this->cache->forget($objectId);
} else {
- $this->cache->clear();
+ $this->cache->flush();
}
}
@@ -374,7 +371,7 @@
}
}
$crumbs[] = [
- 'name' => $term->name,
+ 'name' => html_entity_decode($term->name),
'url' => get_term_link($term, $taxonomy)
];
}
--
Gitblit v1.10.0