From c4aa5cdb5e90ad4b420e22772797d16980232a2b Mon Sep 17 00:00:00 2001
From: Jake Vanderwerf <get@jakevanderwerf.ca>
Date: Wed, 15 Apr 2026 18:38:55 +0000
Subject: [PATCH] =Updating custom tables to utilize CustomTable.php

---
 inc/managers/DashboardManager.php |  296 +++++++++++++++++++++++++++-------------------------------
 1 files changed, 138 insertions(+), 158 deletions(-)

diff --git a/inc/managers/DashboardManager.php b/inc/managers/DashboardManager.php
index 20fbfd8..a6fea2d 100644
--- a/inc/managers/DashboardManager.php
+++ b/inc/managers/DashboardManager.php
@@ -1,9 +1,11 @@
 <?php
 namespace JVBase\managers;
 
-use JVBase\forms\TaxonomySelector;use JVBase\managers\CRUD;
-use JVBase\meta\MetaManager;
-use JVBase\utility\Features;
+use JVBase\forms\TaxonomySelector;
+use JVBase\managers\CRUD;
+use JVBase\meta\Form;
+use JVBase\meta\Meta;
+use JVBase\registrar\Registrar;use JVBase\utility\Features;
 use JVBase\ui\Navigation;
 use WP_User;
 
@@ -17,18 +19,19 @@
 class DashboardManager
 {
     protected WP_User $user;
-    protected CacheManager $cache;
+    protected Cache $cache;
     protected string $role;
 	protected string $baseURL;
     protected int $userLink;
 
     public function __construct()
     {
-        $this->cache = CacheManager::for('dashboard', WEEK_IN_SECONDS);
+        $this->cache = Cache::for('dashboard', WEEK_IN_SECONDS)->connect('user');
         add_action('init', [$this, 'registerDashboard']);
         if (!$this->isRegistered()) {
             add_action('init', [$this, 'buildDashboard']);
         }
+		$this->cache->flush();
         $this->user = wp_get_current_user();
         $this->role = jvbUserRole($this->user->ID);
         $this->userLink = (int)get_user_meta($this->user->ID, BASE.'link', true);
@@ -67,18 +70,21 @@
         $singular = 'Dashboard';
         register_post_type(BASE.'dash', array(
             'labels'                => [
-                'name' => $plural,
-                'singular_name' => $singular,
-                'menu_name' => $plural,
-                'add_new' => "Add New {$singular}",
-                'add_new_item' => "Add New {$singular}",
-                'edit_item' => "Edit {$singular}",
-                'new_item' => "New {$singular}",
-                'view_item' => "View {$singular}",
-                'search_items' => "Search {$plural}",
-                'not_found' => "No {$plural} found",
-                'not_found_in_trash' => "No {$plural} found in Trash"
-            ],
+				'name'               => $plural,
+				'singular_name'      => $singular,
+				'menu_name'          => $plural,
+				'name_admin_bar'     => $singular,
+				'add_new'            => "Add New",
+				'add_new_item'       => "Add New {$singular}",
+				'new_item'           => "New {$singular}",
+				'edit_item'          => "Edit {$singular}",
+				'view_item'          => "View {$singular}",
+				'all_items'          => "All {$plural}",
+				'search_items'       => "Search {$plural}",
+				'parent_item_colon'  => "Parent {$plural}:",
+				'not_found'          => "No {$plural} found.",
+				'not_found_in_trash' => "No {$plural} found in Trash.",
+			],
             'menu_icon'             => jvbCSSIcon('gauge'),
             'public'                => true,
             'publicly_queryable'    => true,
@@ -133,14 +139,14 @@
 	}
 
 
-	protected function getConfig(string $page):array
+	protected function getConfig(string $page):Registrar|false
 	{
 		$pages = $this->getAllDashboardPages();
 		$key = array_search($page, $pages);
 		if ($key === false || is_numeric($key)) {
-			return [];
+			return false;
 		}
-		return Features::getConfig($key);
+		return Registrar::getInstance($key)??false;
 	}
 
 	/**
@@ -160,9 +166,9 @@
 
 	protected function getTitle(string $slug):string
 	{
-		$config = $this->getConfig($slug);
-		if (!empty($config)) {
-			return $config['dash_title']??$config['plural'];
+		$registrar = $this->getConfig($slug);
+		if ($registrar) {
+			return $registrar->getConfig('dashboard')['title']??$registrar->getPlural();
 		}
 		return ucwords(str_replace('-', ' ', str_replace('_', ' ', $slug)));
 	}
@@ -207,6 +213,7 @@
 			$page = $this->getCurrentPageTitle();
 			// Check if page exists in allowed pages
 			$allowedPages = $this->getUserAllowedPages();
+
 			if (!in_array($page, $allowedPages)) {
 				error_log("User not allowed to access page: {$page}");
 				$this->redirectToDashboard();
@@ -285,9 +292,9 @@
 
     protected function getDescription(string $page):string
     {
-		$config = $this->getConfig($page);
-        if (!empty($config)) {
-            $description = (array_key_exists('dash_description', $config)) ? $config['dash_description'] : '';
+		$registrar = $this->getConfig($page);
+        if ($registrar) {
+            $description =  $registrar->getConfig('dashboard')['description']??'';
         } else {
 			$description = apply_filters('jvbDashboardDescription', $page);
             switch ($page) {
@@ -335,10 +342,10 @@
 
         // Get current page/section
         $page = $this->getCurrentPageTitle();
-		$config = $this->getConfig($page);
-		if(!empty($config)) {
-			add_filter('jvbLoadingIcon', function() use ($config) {
-				return $config['icon'];
+		$registrar = $this->getConfig($page);
+		if($registrar) {
+			add_filter('jvbLoadingIcon', function() use ($registrar) {
+				return $registrar->getIcon();
 			});
 		}
 		$integrationSlugs = array_map(function($name) {
@@ -350,14 +357,14 @@
 			// Pass along to the Integrations template handler which knows to check for subpages
 			$page = 'integrations';
 		}
-		echo $this->renderDashboard($page);
-		//TODO: Reenable
-//		echo $this->cache->remember(
-//			$page,
-//		 	function() use ($page) {
-//				return $this->renderDashboard($page);
-//		 	}
-//		);
+//		echo $this->renderDashboard($page);
+
+		echo $this->cache->remember(
+			$page,
+		 	function() use ($page) {
+				return $this->renderDashboard($page);
+		 	}
+		);
 
 		return '';
     }
@@ -376,6 +383,7 @@
 		$this->renderHeader();
 		// Pass to page handler
 		$constantSlug = $this->getConstantSlug($page);
+
         echo apply_filters(
 			'jvbDashboardPage',
 			$this->renderPage($page),
@@ -510,8 +518,8 @@
 		if (!is_singular(BASE.'dash') && !is_post_type_archive(BASE.'dash')) {
             return;
         }
-		wp_enqueue_style('jvb-icons-dash');
-		wp_enqueue_style('jvb-icons-forms');
+		IconsManager::for('forms')->enqueueIconStyles();
+		IconsManager::for('dash')->enqueueIconStyles();
 
 		wp_enqueue_script('jvb-form');
 		wp_enqueue_script('jvb-selector');
@@ -532,28 +540,28 @@
 					break;
                 case 'admin':
                 case 'dash':
-                    if (current_user_can('manage_options') && apply_filters('jvbAdminDashboard', '') === '') {
-                        wp_enqueue_script(
-                        'jvb-admin',
-                        JVB_URL . 'assets/js/min/admin.min.js',
-                        [
-                            'jvb-queue',
-                            'jvb-loading'
-                        ],
-                        [
-                            'strategy' => 'defer',
-                            'in_footer' => true
-                        ]
-                    );
+//                    if (current_user_can('manage_options') && apply_filters('jvbAdminDashboard', '') === '') {
+//                        wp_enqueue_script(
+//                        'jvb-admin',
+//                        JVB_URL . 'assets/js/min/admin.min.js',
+//                        [
+//                            'jvb-queue',
+////                            'jvb-loading'
+//                        ],
+//                        [
+//                            'strategy' => 'defer',
+//                            'in_footer' => true
+//                        ]
+//                    );
 
-                    wp_localize_script(
-                        'jvb-admin',
-                        'jvbAdmin',
-                        [
-                            'nonce' => wp_create_nonce('itsme')
-                        ]
-                    );
-                    }
+//                    wp_localize_script(
+//                        'jvb-admin',
+//                        'jvbAdmin',
+//                        [
+//                            'nonce' => wp_create_nonce('itsme')
+//                        ]
+//                    );
+//                    }
 					break;
 				case 'seo':
 					wp_enqueue_script('jvb-schema');
@@ -594,8 +602,7 @@
         if (!$post) {
             return '';
         }
-
-        return $post->post_title;
+        return html_entity_decode($post->post_title);
     }
    protected function getCurrentPageSlug():string
     {
@@ -615,10 +622,11 @@
 		return $this->cache->remember('icon_'.sanitize_title($page), function() use ($slug, $page) {
 			$icon = sanitize_title($page);
 			if (!is_numeric($slug)) {
-				$config = Features::getConfig($slug);
-				if (array_key_exists('icon', $config)) {
-					$icon = $config['icon'];
+				$registrar =Registrar::getInstance($slug);
+				if ($registrar) {
+				return $registrar->getIcon();
 				}
+
 			}
 			return $icon;
 		});
@@ -735,9 +743,12 @@
 
 		//Content
 			//content types
-				//Taxonomies
-		$availableContent = array_filter($pages, function($page, $key) {
-			return !is_numeric($key) && array_key_exists($key, JVB_CONTENT);
+		$all = array_merge(
+			Registrar::getRegistered('post'),
+			Registrar::getFeatured('is_content', 'term')
+		);
+		$availableContent = array_filter($pages, function($page, $key) use($all) {
+			return !is_numeric($key) && in_array($key, $all) && JVB()->roles()->checkRole($this->user, $key);
 		}, ARRAY_FILTER_USE_BOTH);
 		if (!empty ($availableContent)){
 			$content = $menu->addItem('Your Content', jvbDashIcon('book-bookmark'))
@@ -745,25 +756,30 @@
 				->defaultMenuClasses($menuClasses)
 				->defaultItemClasses($itemClasses);
 			foreach ($availableContent as $slug => $page) {
-				$config = JVB_CONTENT[$slug];
-				$item = $content->addItem($page, jvbDashIcon($config['icon']))
+				$registrar = Registrar::getInstance($slug);
+
+				$item = $content->addItem($page, $registrar->getIcon())
 					->url($this->baseURL.'/'.$slug);
 
-				$taxonomies = array_filter(JVB_TAXONOMY, function ($value, $key) use ($slug) {
-					return in_array($slug, $value['for_content']);
-				},1);
-				if (!empty ($taxonomies)) {
-					//TODO: If we add a dedicated 'create item' page, remove this from the empty check
-					$itemMenu = $item->submenu($slug);
-					foreach ($taxonomies as $s => $config) {
-						$itemMenu->addItem($config['plural'], $config['icon'])
-							->url($this->baseURL.'/'.$s);
+				if ($registrar->getType() === 'post') {
+					$taxonomies = $registrar->registrar->taxonomies;
+					if (!empty ($taxonomies)) {
+						//TODO: If we add a dedicated 'create item' page, remove this from the empty check
+						$itemMenu = $item->submenu($slug);
+						foreach ($taxonomies as $s) {
+							$taxRegistrar = Registrar::getInstance($s);
+							$itemMenu->addItem($taxRegistrar->getPlural(), $taxRegistrar->getIcon())
+								->url($this->baseURL.'/'.$s);
+						}
 					}
 				}
 
+
 			}
 		}
 
+		//Taxonomies
+
 		//Settings
 		$settings = $menu->addItem('Settings', jvbDashIcon('faders'))
 			->submenu('settings')
@@ -868,7 +884,7 @@
 
         echo '<h2>What would you like to do today?</h2>';
 
-        echo '<ul>';
+        echo '<ul class="dashboard">';
         foreach ($pages as $slug => $page) {
 			if ($page === 'dash') {
 				continue;
@@ -965,7 +981,7 @@
 		$connection = (array_key_exists($page, $map)) ? $map[$page] : $page;
 		if ($connection !== 'integrations') {
 
-			$userID = (jvbSiteHasMembership()) ? $this->user->ID : null;
+			$userID = (Features::forSite()->has('has_membership')) ? $this->user->ID : null;
 			$integration = JVB()->connect($connection, $userID);
 
 			echo '<h1>Managing '.$integration->title.'</h1>';
@@ -1072,20 +1088,19 @@
         <nav class="tabs row start" role="tablist">
         <?php
         $i=1;
-        $content = JVB_CONTENT;
-        $contentTax = array_filter(JVB_TAXONOMY, function ($tax) {
-            return jvbCheck('is_content', $tax);
-        });
-        $taxonomies = JVB_TAXONOMY;
-        foreach($contentTax as $key => $config) {
-            unset($taxonomies[$key]);
+        $content = Registrar::getRegistered('post');
+        $contentTax = Registrar::getFeatured('is_content', 'term');
+        $taxonomies = Registrar::getRegistered('term');
+        foreach($contentTax as $index => $tax) {
+            unset($taxonomies[$index]);
         }
         $content = array_merge($content, $contentTax);
-        foreach ($content as $type => $settings) {
+        foreach ($content as $type) {
+			$registrar = Registrar::getInstance($type);
             $active = ($i === 1) ? ' active' : '';
             ?>
             <button type="button" class="tab<?=$active?>" data-tab="<?=$type?>" role="tab" aria-selected="<?= ($active !== '') ? 'true' : 'false'?>">
-                <h2><?=jvbDashIcon($settings['icon']??$key)?> <?= $settings['plural'] ?></h2>
+                <h2><?=jvbDashIcon($registrar->getIcon())?> <?= $registrar->getPlural() ?></h2>
             </button>
             <?php
             $i++;
@@ -1096,8 +1111,9 @@
             <option> ... Taxonomy</option>
             <?php
 
-            foreach ($taxonomies as $type => $settings) {
-                echo '<option value="'.$type.'">'.$settings['plural'].'</option>';
+            foreach ($taxonomies as $type) {
+				$taxRegistrar = Registrar::getInstance($type);
+                echo '<option value="'.$type.'">'.$taxRegistrar->getPlural().'</option>';
             }
             ?>
         </select>
@@ -1121,11 +1137,10 @@
 
     <?php
 
-    $jvb_everything = array_merge(JVB_CONTENT, JVB_TAXONOMY);
 
-    foreach ($jvb_everything as $type => $settings) {
-        $meta = new MetaManager(null, 'form');
-        $fields = jvbGetFields($type);
+
+    foreach (Registrar::getRegistered() as $type) {
+        $fields = Registrar::getFieldsFor($type);
         ?>
         <template class="<?= $type ?>Table">
             <table>
@@ -1194,7 +1209,7 @@
                             <?php
                             $config['type'] = 'text';
                             $config['description'] = '';
-                            $meta->render('form', $n, $config);
+                            Form::render($n, null, $config);
                             ?>
                         </td>
                         <?php
@@ -1209,10 +1224,9 @@
         echo jvbNewModal(
             'edit-modal '.$type,
             'Edit '.ucfirst($type),
-            $meta->renderForm('admin', [], $fields)
+            jvbRenderForm('admin', $fields)
         );
         }
-
 		return ob_get_clean();
     }
 
@@ -1268,7 +1282,7 @@
 				$pages[] = 'Favourites';
 			}
 
-			if (Features::anyContentHas('karma') || Features::anyTaxonomyHas('karma') || Features::anyUserHas('karma')) {
+			if (!empty(Registrar::getFeatured('karma'))) {
 				$pages[] = 'Karmic Score';
 			}
 
@@ -1285,12 +1299,14 @@
 			}
 
 			// Add all content types (with config keys)
-			foreach (JVB_CONTENT as $slug => $config) {
-				$pages[$slug] = $config['plural'];
+			foreach (Registrar::getRegistered('post') as $slug) {
+				$registrar = Registrar::getInstance($slug);
+				$pages[$slug] = $registrar->getPlural();
 			}
 
-			foreach (JVB_TAXONOMY as $slug=>$config) {
-				$pages[$slug] = $config['plural'];
+			foreach (Registrar::getRegistered('term') as $slug) {
+				$registrar = Registrar::getInstance($slug);
+				$pages[$slug] = $registrar->getPlural();
 			}
 
 			// Allow filtering
@@ -1317,7 +1333,7 @@
 	{
 		$role = jvbNoBase($role);
 
-		if (!array_key_exists($role, JVB_USER)) {
+		if (!Registrar::getInstance($role)){
 			return [];
 		}
 
@@ -1344,15 +1360,14 @@
 		}
 
 
-		$cacheKey = "user_pages_{$userID}";
-		$pages = $this->cache->get($cacheKey);
-		$pages = false;
+		$pages = $this->cache->get($userID);
+
 		if ($pages === false || JVB_TESTING) {
 			if (user_can($userID, 'manage_options')) {
 				// Admin gets all pages as flat array
 				$pages = $this->getAllDashboardPages();
 				// Extract just the values (slugs)
-				$this->cache->set($cacheKey, $pages, WEEK_IN_SECONDS);
+				$this->cache->set($userID, $pages, WEEK_IN_SECONDS);
 				return $pages;
 			}
 			$roles = array_map('jvbNoBase', $user->roles);
@@ -1363,21 +1378,22 @@
 				//Default to Remove pages
 				$remove = true;
 				if (!is_numeric($key)) {
-					$type  = Features::getType($key);
+					$registrar = Registrar::getInstance($key);
+					$type  = $registrar? $registrar->getType() : false;
 					if ($type) {
-						$permission = RoleManager::getPlural($key);
+						$permission = JVB()->roles()->getPermission('edit', $key);
 					}
 					switch ($type) {
 						case 'content':
-							if (user_can($userID, "edit_{$permission}")) {
+							if (user_can($userID, $permission)) {
 								$remove = false;
 							}
 							break;
 						case 'taxonomy':
-							$config = Features::getConfig($key, 'taxonomy');
-							if (array_key_exists('is_content', $config) && $config['is_content'] && (user_can($userID, "own_{$key}") || user_can($userID, "manage_{$key}"))) {
+							$registrar = Registrar::getInstance($key);
+							if ($registrar && $registrar->hasFeature('is_content') && (!empty(JVB()->roles()->getOwnedTerms($userID, $key)) || !empty(JVB()->roles()->getManagedTerms($userID, $key)))){
 								$remove = false;
-							} else if (count(array_intersect($config['for_content'], array_keys($pages))) > 0) {
+							} else if (count(array_intersect($registrar->registrar->for, array_keys($pages))) > 0) {
 								$remove = false;
 							}
 							break;
@@ -1399,7 +1415,8 @@
 								}
 							}
 							if ($remove) {
-								if ($canSkip || array_key_exists('invitable', $config)) {
+								//TODO: Figure out what $config was supposed to be
+								if ($canSkip || ($registrar && $registrar->hasFeature('invitable'))) {
 									$remove = false;
 								}
 							}
@@ -1446,11 +1463,8 @@
 							foreach ($roles as $role) {
 								$contents = Features::forUser($role)->getCreatableContent();
 								if (!empty($contents)) {
-									foreach($contents as $content) {
-										if (Features::forContent($content)->has('karma')) {
-											$remove = false;
-										}
-									}
+									$hasKarma = Registrar::getFeatured('karma');
+									$remove = empty(array_intersect($contents, $hasKarma));
 								}
 							}
 							break;
@@ -1474,7 +1488,7 @@
 			$pages = apply_filters('jvbUserDashboardPages', $pages, $user->roles, $userID);
 			$pages = array_unique($pages);
 
-			$this->cache->set($cacheKey, $pages, WEEK_IN_SECONDS);
+			$this->cache->set($userID, $pages, WEEK_IN_SECONDS);
 		}
 
 		return $pages;
@@ -1510,9 +1524,7 @@
 	 */
 	protected function getRolesWithDashboard():array
 	{
-		return array_keys(array_filter(JVB_USER, function ($role) {
-			return Features::forUser(array_search($role, JVB_USER))->has('has_dashboard');
-		}));
+		return Registrar::getFeatured('has_dashboard', 'user');
 	}
 
 	/**
@@ -1532,36 +1544,4 @@
 		return count(array_intersect($dashboardRoles, $userRoles)) > 0;
 	}
 
-	/**
-	 * Get the capability needed to access a content type
-	 * @param string $type
-	 * @return string
-	 */
-	protected function getPermissionForType(string $type):string
-	{
-		// Check if it's a registered content type
-		if (array_key_exists($type, JVB_CONTENT)) {
-			$plural = JVB_CONTENT[$type]['plural'];
-			return 'edit_'.$plural;
-		}
-
-		// Default to edit_{type}s
-		return 'edit_'.$type.'s';
-	}
-
-	/**
-	 * Invalidate dashboard page cache for a user or all users
-	 * Call this when user roles or permissions change
-	 * @param int|null $userID Specific user to invalidate, null for all
-	 * @return void
-	 */
-	public function invalidatePagesCache(?int $userID = null):void
-	{
-		if ($userID !== null) {
-			$this->cache->delete("user_pages_{$userID}");
-		} else {
-			// Invalidate all user caches by invalidating the group
-			$this->cache->invalidate();
-		}
-	}
 }

--
Gitblit v1.10.0