From c68aefb847b09daa0697de7684d3451e2e68ce1e Mon Sep 17 00:00:00 2001
From: Jake Vanderwerf <get@jakevanderwerf.ca>
Date: Thu, 09 Jul 2026 23:10:23 +0000
Subject: [PATCH] =Refactor of Integrations.php to be a bit more useful with a suite of methods for create, update, delete back and forths for integrations where sharing is enabled. Also considering a single instance with a connect method to connect as the site (no user) vs connecting as an individual user - rather than recreating instances for every user.

---
 inc/registrar/helpers/AddIntegrationFields.php |   16 ++++++++++++----
 1 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/inc/registrar/helpers/AddIntegrationFields.php b/inc/registrar/helpers/AddIntegrationFields.php
index 29fe741..6aad5fa 100644
--- a/inc/registrar/helpers/AddIntegrationFields.php
+++ b/inc/registrar/helpers/AddIntegrationFields.php
@@ -11,13 +11,13 @@
 
 class AddIntegrationFields {
 	protected string $service_name;
-	protected Registrar $registrar;
+	private Registrar $registrar;
 	protected Integration $config;
 	protected array $allowed;
 
 	public function __construct(string $service_name, ?Registrar $registrar = null) {
 		$this->initAllowed();
-		if (!in_array($service_name, $this->allowed)) {
+		if (!array_key_exists($service_name, $this->allowed)) {
 			return;
 		}
 
@@ -28,6 +28,7 @@
 
 		$this->config = $registrar->getIntegration($service_name);
 
+		add_action('jvb_define_integrations', [$this, 'addIntegrationFields'],20);
 	}
 	protected function initAllowed():void
 	{
@@ -56,6 +57,7 @@
 	public function addIntegrationFields():void
 	{
 		$fields = $this->getIntegrationFields();
+//		error_log('[AddIntegrationFields] adding fields for '.$this->service_name.': '.print_r($fields, true));
 		foreach ($fields as $fieldName => $fieldConfig) {
 			$this->registrar->fields()->addField($fieldName, $fieldConfig);
 		}
@@ -63,11 +65,15 @@
 
 	public function getIntegrationFields():array
 	{
+		if ($this->registrar && $this->registrar->getType() === 'user' && $this->config->isCustomer()) {
+			return JVB()->connect($this->service_name)->getAdditionalFields('customer');
+		}
 		$fields = [
 			'share_to_'.$this->service_name => [
 				'type'	=> 'true_false',
 				'label'	=> 'Share To '.$this->allowed[$this->service_name],
 				'section'	=> 'sync',
+				'default'	=> 1
 			]
 		];
 		if ($this->config->getUpdate()){
@@ -79,7 +85,8 @@
 					'field'	=> 'share_to_'.$this->service_name,
 					'value'	=> 1,
 					'operator'	=> '=='
-				]
+				],
+				'default'	=> 1,
 			];
 
 			$fields["_{$this->service_name}_item_id"] = [
@@ -123,7 +130,8 @@
 					'field' => 'share_to_'.$this->service_name,
 					'operator' => '==',
 					'value' => 1
-				]
+				],
+				'default'	=> 1,
 			];
 		}
 		$additional = JVB()->connect($this->service_name)->getAdditionalFields($this->config->getContentType());

--
Gitblit v1.10.0